feat(cdn): add cdn client, config, list command #1100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenhoenle
reviewed
Nov 19, 2025
rubenhoenle
reviewed
Nov 19, 2025
rubenhoenle
reviewed
Nov 19, 2025
rubenhoenle
reviewed
Nov 19, 2025
Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>
Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>
rubenhoenle
reviewed
Nov 19, 2025
rubenhoenle
reviewed
Nov 19, 2025
rubenhoenle
reviewed
Nov 19, 2025
Member
|
Btw, please always add the Jira issue ID to your PR description if possible :) |
cgoetz-inovex
commented
Nov 20, 2025
rubenhoenle
reviewed
Dec 5, 2025
rubenhoenle
reviewed
Dec 5, 2025
rubenhoenle
reviewed
Dec 5, 2025
rubenhoenle
reviewed
Dec 5, 2025
rubenhoenle
reviewed
Dec 5, 2025
rubenhoenle
reviewed
Dec 5, 2025
rubenhoenle
reviewed
Dec 5, 2025
rubenhoenle
reviewed
Dec 5, 2025
rubenhoenle
reviewed
Dec 5, 2025
rubenhoenle
reviewed
Dec 5, 2025
rubenhoenle
reviewed
Dec 5, 2025
Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>
- replace single char names with more descriptive ones - remove predefined mod functions - deduplicate ParseOriginRequestHeaders and test it - deduplicate ParseGeofencing and test it - add test FlagTo* funcs
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
Merging this branch changes the coverage (1 decrease, 10 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Merging this branch changes the coverage (1 decrease, 10 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
rubenhoenle
reviewed
Jan 8, 2026
rubenhoenle
previously approved these changes
Jan 8, 2026
| return err | ||
| } | ||
| if model.Bucket != nil { | ||
| pw, err := params.Printer.PromptForPassword("enter your secret access key for the object storage bucket: ") |
Member
There was a problem hiding this comment.
How does this work with scripts? Could you add an example please which shows this use-case? 😅
Contributor
Author
There was a problem hiding this comment.
nice catch, Print.PromptForPassword would need some changes:
@@ -172,11 +172,16 @@ func (p *Printer) PromptForEnter(prompt string) error {
func (p *Printer) PromptForPassword(prompt string) (string, error) {
p.Cmd.PrintErr(prompt)
defer p.Outputln("")
- bytePassword, err := term.ReadPassword(int(syscall.Stdin))
- if err != nil {
- return "", fmt.Errorf("read password: %w", err)
+ if term.IsTerminal(syscall.Stdin) {
+ bytePassword, err := term.ReadPassword(int(syscall.Stdin))
+ if err != nil {
+ return "", fmt.Errorf("read password: %w", err)
+ }
+ return string(bytePassword), nil
}
- return string(bytePassword), nil
+ // Fallback for non-terminal environments
+ reader := bufio.NewReader(p.Cmd.InOrStdin())
+ return reader.ReadString('\n')
}
With this a script like:
#!/usr/bin/env bash
cat secret | bin/stackit beta cdn distribution create -y --project-id xxx --bucket --bucket-url https://bucket.example.com \
--bucket-credentials-access-key-id yyyy --bucket-region EU \
--regions AF,EU
works.
Should we change Print.PromptForPassword accordingly?
Other commands (observability-credentials/update; loadbalancer/add) read passwords as command line arguments, which can be read by other processes.
Imo we should use env vars and/or stdin.
Member
There was a problem hiding this comment.
I would prefer stdin, else we have a mess with hundreds of env variables some day 😅
Member
There was a problem hiding this comment.
Should we change Print.PromptForPassword accordingly?
yes, please. If you're confident to do that do it within this PR. If not please create a Jira issue for it and bring it up in the refinement @cgoetz-inovex 😅
Member
There was a problem hiding this comment.
Other commands (observability-credentials/update; loadbalancer/add) read passwords as command line arguments, which can be read by other processes.
Also please feel free to open Jira issues for these args so we can deprecate them in the future and replace them with appropriate input methods. 😉
- fix `ID` spelling - add missing new line at end of output - rm TODO comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: STACKITCLI-70
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)